gh-128639: Don't assume one thread in subinterpreter finalization #128640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
commented
Jan 8, 2025
| Py_NewInterpreter(); | ||
| Py_NewInterpreter(); | ||
| Py_NewInterpreter(); | ||
| PyThreadState *tstate = PyThreadState_Get(); |
There was a problem hiding this comment.
I think this test working before was a fluke. Py_NewInterpreter changes the thread state, and I don't think we support calling Py_Finalize from a subinterpreter.
There was a problem hiding this comment.
It's probably okay but your change helps future-proof the test.
ericsnowcurrently
requested changes
May 19, 2025
| Py_NewInterpreter(); | ||
| Py_NewInterpreter(); | ||
| Py_NewInterpreter(); | ||
| PyThreadState *tstate = PyThreadState_Get(); |
There was a problem hiding this comment.
It's probably okay but your change helps future-proof the test.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Eric Snow <[email protected]>
ericsnowcurrently
approved these changes
May 19, 2025
|
@hugovk, is this something you'd be okay with us backporting to 3.14? |
|
Yep, crash bugfixes can be backported :) |
|
Thanks @ZeroIntensity for the PR, and @ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 19, 2025
…on (pythongh-128640) Incidentally, this also fixed the warning not showing up if a subinterpreter wasn't cleaned up via _interpreters.destroy. I had to update some of the tests as a result. (cherry picked from commit 9859791) Co-authored-by: Peter Bierma <[email protected]>
|
GH-134254 is a backport of this pull request to the 3.14 branch. |
|
ZeroIntensity
added a commit
to ZeroIntensity/cpython
that referenced
this pull request
May 19, 2025
…nalization (pythongh-128640)" This reverts commit 9859791.
ericsnowcurrently
pushed a commit
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incidentally, this also fixed the warning not showing up if a subinterpreter wasn't cleaned up via
_interpreters.destroy. I had to update some of the tests as a result.